-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for automatic bridge selection in HW offload mode #301
Add support for automatic bridge selection in HW offload mode #301
Conversation
Hi @ykulazhenkov. Thanks for your PR. I'm waiting for a k8snetworkplumbingwg member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
34f16be
to
a588970
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ykulazhenkov hi. I believe that @SchSeba is planning to review this and help getting it merged once he's back at work. |
Hi @ykulazhenkov can you please rebase I would like to see the github actions green on this one |
a588970
to
2dd3e28
Compare
@SchSeba done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks I like this image!
just one comment that I am not sure
2dd3e28
to
9317a26
Compare
pkg/plugin/plugin.go
Outdated
bridgeName, err = driver.FindBridgeByInterface(uplinkName) | ||
if err != nil { | ||
errList = append(errList, | ||
fmt.Errorf("failed to get bridge name - failed to find bridge name by uplink name %s: %v", bridgeName, err)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bridgeName -> uplinkName
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
If deviceID argument is passed it can be used for automatic bridge selection: VF deviceID > PF > Bond(Optional) > Bridge Signed-off-by: Yury Kulazhenkov <[email protected]>
9317a26
to
58fb6d4
Compare
@SchSeba |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: e0ne, SchSeba, ykulazhenkov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Add support for automatic bridge selection in HW offload mode
If deviceID argument is passed it can be used for automatic bridge selection: VF deviceID > PF > Bond(Optional) > Bridge
What this PR does / why we need it:
This is required to optimize HW offloading use-case when Virtual Functions from multiple NICs on a host are exposed as a single resource.
Example:
We have two NICs on a host, and we want to expose all VFs from these NICs as a single resource.
To support HW offloading, each NIC should be attached to a separate OVS bridge.
Without changes from this PR, it is not possible to define NetworkAttachDefinition for OVS-cni, which will cover this use-case, because you need to explicitly specify the bridge name in the CNI config.
After changes from this PR, it is possible to define NetworkAttachDefinition without the bridge name and rely on the fact that ovs-cni will be able to automatically select the right OVS bridge (bridge to which NIC is attached) from the allocated Virtual Function (allocated by sriov device plugin, injected in
deviceID
field by multus)Special notes for your reviewer:
Context is Software bridge management feature in sriov-network-operator
Release note:
cc @zeeke @adrianchiris @SchSeba